refactoring - Is there more idiomatic ruby to perform this iteration? -

-

i iterating through set of ids , want return first object returns true when predicate method called on it. few lines of code worth thousand words:

def applicable_question(question_ids)   ordered_ids(question_ids, order).detect |question_id|     question = question.find_by(id: question_id)     return question if question.applicable_for?(self)   end end

stripping away domain terms:

def desired_thing(ids)   ids.detect |id|     thing = thing.new(id)     return thing if thing.true?   end end

is there more idiomatic approach here? specifically, feel abusing detect. reached each , break, didn't far approach.

a requirement code not need instantiate large array of objects (activerecord subtypes example) find desired thing.

you have:

desired_thing = ids.detect |id|   thing = thing.new(id)   return thing if thing.true? end

if thing found thing.true? true, detect never returns element of ids (to assigned desired_thing) because it's preempted return. on other hand, if block completes without return being invoked, detect returns nil , assigns value desired_thing, nil value of no use in code follows. therefore better write:

ids.each |id|   thing = thing.new(id)   return thing if thing.true? end

Comments

Post a Comment

Popular posts from this blog

node.js - How to mock a third-party api calls in the backend -

-
i'm testing application mocha , supertest, test like var request = require('supertest'), app = require('./bootstrap.js'); describe('...', function() { it('...', function() { request(app) .get('/some/url') // ... }); }); the bootstrap.js real application before listen ports all works perfect have add calls third-party api , testing slow so when do, test example takes 5 seconds request(app) .get('/my/endpoint/that/makes/call/others') // ... how can make fake calls during test real when running application? you can use nock purpose.
Read more

node.js - Why do I get "SOCKS connection failed. Connection not allowed by ruleset" for some .onion sites? -

-
i'm experimenting node , socks5-https-client . reason, tor hidden service ( .onion ) sites return connection error. for example, connecting duckduckgo ( 3g2upl4pq6kufc4m.onion ) works , returns html. however, connecting pirate bay ( uj3wazyk5u4hnvtk.onion ) or torch ( xmh57jrzrnw6insl.onion ) returns... error: socks connection failed. connection not allowed ruleset. what error mean? how can avoid it? here's code reproduce it: var shttps = require('socks5-https-client'); shttps.get({ hostname: '3g2upl4pq6kufc4m.onion', path: '', sockshost: '127.0.0.1', socksport: 9150, rejectunauthorized: false }, function(res) { res.setencoding('utf8'); res.on('readable', function() { console.log(res.read()); // log response console. }); }); the error seems caused 0x02 value in field 2 of server response. in summary the servers you're failing access don't support ...
Read more

java - Cannot resolve constructor when using ArrayAdapter -

-
i'm getting myself in muddle arrayadapter i'm trying put together. i've got constructor, person, used put people go in list. i'm putting arraylist of type person make readable list. i put arrayadapter list can seen in listview, i'm getting "cannot resolve constructor" code. i've tried countless possible solutions on site including trying use getactivity() or in place of peopleactivity.this, cannot code compile. i've tried referencing constructor class in arrayadapter, gives me error it's not enclosing class. person.class (constructor) import android.text.editable; public class person { public person person; private editable personname; public person(editable a) { personname = a; } public void setname(editable personname){ this.personname = personname; } public editable getname() { return personname; } } peopleactivity - populatelistview arraylist<person> peoplelistv = new arraylist<person>(); ... ...
Read more